Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DevTools survey metadata location #6976

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Update DevTools survey metadata location #6976

merged 1 commit into from
Dec 18, 2023

Conversation

kenzieschmoll
Copy link
Member

This file was moved to the flutter/uxr repo: flutter/uxr#127
Deleted from the website and added a redirect for old versions here: flutter/website#9935

@kenzieschmoll kenzieschmoll requested a review from a team as a code owner December 15, 2023 21:26
@kenzieschmoll kenzieschmoll requested review from polina-c and removed request for a team December 15, 2023 21:26
@kenzieschmoll
Copy link
Member Author

We cannot access the survey metadata file at the new URL due to CORS issues:

home:1 Access to XMLHttpRequest at
'https://storage.googleapis.com/flutter-uxr/surveys/devtools-survey-metadata.json' from origin 
'http://127.0.0.1:9102' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is 
present on the requested resource.

We may have to revert flutter/website#9935 if the cross origin issue cannot be resolved. CC @khanhnwin @jayoung-lee @eliasyishak in case you have ideas on how to resolve this. I wonder if we can loosen the CORS access restrictions on the survey metadata resources.

@jayoung-lee
Copy link

@khanhnwin might have a better idea than myself

@kenzieschmoll
Copy link
Member Author

The work to fix the cross origin access errors is being tracked at flutter/uxr#128

@kenzieschmoll kenzieschmoll merged commit 11d2c86 into flutter:master Dec 18, 2023
23 of 24 checks passed
@kenzieschmoll kenzieschmoll deleted the surveys branch December 18, 2023 19:48
kenzieschmoll added a commit to kenzieschmoll/devtools that referenced this pull request Dec 20, 2023
@kenzieschmoll
Update DevTools survey metadata location (flutter#6976)
2755676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenzieschmoll @jayoung-lee @polina-c